refactor: document and expose Amino DHT defaults #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the intention here is to have public source of truth we can reference rather than hardcoding the same amino defaults everywhere
guillaumemichel
approved these changes
Sep 20, 2024
gammazero
approved these changes
Sep 20, 2024
| @@ -20,7 +21,7 @@ type options struct { | |||
| // defaults are the default crawler options. This option will be automatically | |||
| // prepended to any options you pass to the crawler constructor. | |||
| var defaults = func(o *options) error { | |||
| o.protocols = []protocol.ID{"/ipfs/kad/1.0.0"} | |||
| o.protocols = amino.Protocols | |||
| o.parallelism = 1000 | |||
| o.connectTimeout = time.Second * 5 | |||
| o.perMsgTimeout = time.Second * 5 | |||
There was a problem hiding this comment.
Should these be defined in defaults.go as well, even if not exported?
There was a problem hiding this comment.
These seem to be specific to crawler and really part of "Amino DHT contract", so could
I'm going to merge thus PR as-is, we can figure out what to do remaining magic numbers in follow-up PR.
| o.Resiliency = 3 | ||
| o.BucketSize = amino.DefaultBucketSize | ||
| o.Concurrency = amino.DefaultConcurrency | ||
| o.Resiliency = amino.DefaultResiliency | ||
| o.LookupCheckConcurrency = 256 |
There was a problem hiding this comment.
Another candidate for defaults? Also, wish there was some explanation why 256 is the chosen value for concurrency.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here is to have
github.com/libp2p/go-libp2p-kad-dht/aminoas a single public source of truth about Amino DHT we can reference rather than hardcoding the same defaults everywhere in IPFS implementations (boxo, kubo etc).