UsefulPeer function #113
Merged
UsefulPeer function #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MarcoPolo
requested changes
May 22, 2023
Jorropo
reviewed
Jun 6, 2023
Jorropo
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
I agree with @MarcoPolo your use .min is weird and require to know it's side effects, I would consider changing it. You can keep it like this because this was how the code you copied it from already worked.
guillaumemichel
force-pushed
the
feat/useful-peer
branch
from
36b259f
to
43db441
Compare
Co-authored-by: Jorropo <jorropo.pgm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UsefulPeer verifies whether a given peer.ID would be a good fit for the routing table. It returns true if the bucket corresponding to peer.ID isn't full, if it contains replaceable peers or if it is the last bucket and adding a peer would unfold it.
This function is necessary for go-libp2p-kad-dht, as remote DHT servers are queried before they are added to the DHT. We don't want to query peers whose ID belong to a full bucket anyway. This function helps preventing querying useless peers.
References: libp2p/go-libp2p-kad-dht#820