Reduce allocs in AddPeer #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
Stebalien
approved these changes
May 8, 2020
table.go
Outdated
| rt.PeerAdded(p) | ||
| return true, nil | ||
| } | ||
| pid := bucket.selectFirst(func(pi *PeerInfo) bool { |
There was a problem hiding this comment.
ot nit: shouldn't we pick the least useful peer?
There was a problem hiding this comment.
@Stebalien What's the meaning of "ot nit" ?
There was a problem hiding this comment.
Sorry, "off topic nit". That is, a small suggestion that isn't even related to the current patch (just something I noticed while reviewing it).
(I'm basically saying "feel free to ignore this for now, but we should fix this in a future patch").
|
@Stebalien While I'm not really sure how much of an impact it will have, I've changed the code to use the least useful peer as it sounds like the right thing to do. Please take a look when you can ! |
Stebalien
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Stebalien
For libp2p/go-libp2p-kad-dht#594.