Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

switch to a faster metrics library #8

Merged
merged 6 commits into from
Dec 11, 2017
Merged

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Dec 11, 2017

@ghost ghost assigned Stebalien Dec 11, 2017
@ghost ghost added the in progress label Dec 11, 2017
It shows that this branch is about 4x faster (in this likely unrealistic case).
At the very least, this library shouldn't be slower.
@Stebalien
Copy link
Member Author

For further motivation, see the goroutine dump at the bottom of ipfs/kubo#2823.

Copy link
Contributor

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge when ready

@Stebalien Stebalien merged commit 876ac63 into master Dec 11, 2017
@ghost ghost removed the in progress label Dec 11, 2017
@Stebalien Stebalien deleted the feat/faster-metrics branch December 11, 2017 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics shouldn't slow us down
2 participants