This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Protobuf and JSON (un-)marshalling methods for peer.ID #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
reviewed
Dec 12, 2018
peer_serde.go
Outdated
| import ( | ||
| "encoding/json" | ||
|
|
||
| "github.com/golang/protobuf/proto" |
There was a problem hiding this comment.
This pulls protobuf into quite a few deps. Given that it's only for a type assertion, I'd rather just leave it out for now.
Once we merge all the "core" deps into a single package, we can do stuff like this without complicating our lives quite as much.
If you think we should keep it, we'll have to add it to the package.json.
There was a problem hiding this comment.
👍 SGTM, will comment out the assertions to keep them as docs.
Stebalien
approved these changes
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: libp2p/go-libp2p-peerstore#47