This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Fix perfomance issue in updating addr book #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix_update_addrbook_loop
branch
from
545b1c0
to
25f38ee
Compare
Stebalien
approved these changes
Jul 20, 2021
1. Remove duplicate import. 2. Lift empty check to simplify code. 3. Use a more efficient map key (go will optimize this to not allocate).
Stebalien
force-pushed
the
fix_update_addrbook_loop
branch
from
25f38ee
to
517a484
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent upgrade to latest libp2p libraries I saw that my app runs 10% cpu in idle. After debugging I found that this function sometimes do 40000*80000 (1-4 billion) iterations. I don't known why it gets so many addresses (on average there is only 10-200 addresses), so I only fix this complexity issue.