This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
fix multiple TTL bugs #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix/identify-2
branch
2 times, most recently
from
86be435
to
854f94b
Compare
The first fix independently extends the address expiration time and the address TTL: By example: * We have an address with a TTL of 4s that will expire in 1s. * We update it with a TTL of 3s. Before this change: * We end up with an address with a TTL of 3s that will expire in 3s. After this change: * We end up with an address with a TTL of 4s that will expire in 3s. --- The second fix prevents the in-memory addressbook from announcing existing addresses every time their TTLs get updated. --- The third fix correctly updates TTLs for existing addresses in the on-disk addressbook. This fixes libp2p/go-libp2p-identify#2
Stebalien
force-pushed
the
fix/identify-2
branch
from
854f94b
to
2fb6d7a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first fix independently extends the address expiration time and the address TTL:
By example:
Before this change:
After this change:
The second fix prevents the in-memory addressbook from announcing existing addresses every time their TTLs get updated.
The third fix correctly updates TTLs for existing addresses in the on-disk addressbook.
This fixes libp2p/go-libp2p-identify#2