Remove bootstrapping code #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/discovery
branch
2 times, most recently
from
3561865
to
2fcdcce
Compare
Stebalien
requested changes
Nov 11, 2019
aschmahmann
force-pushed
the
feat/discovery
branch
from
2fcdcce
to
45be97b
Compare
aschmahmann
commented
Dec 2, 2019
aschmahmann
commented
Dec 2, 2019
aschmahmann
commented
Dec 2, 2019
aschmahmann
commented
Dec 2, 2019
Stebalien
requested changes
Dec 6, 2019
aschmahmann
commented
Dec 9, 2019
aschmahmann
force-pushed
the
feat/discovery
branch
2 times, most recently
from
26324c6
to
e81940b
Compare
aschmahmann
commented
Dec 9, 2019
aschmahmann
force-pushed
the
feat/discovery
branch
3 times, most recently
from
c9170fb
to
e6a6cc9
Compare
|
Before I merge this it'd be nice to be able to run CI on the go-ipfs PR that incorporates the change, for extra testing. However, that's currently blocked bc this repo was updated to the latest version of the datastore interface. @Stebalien should I just merge this and we can worry about the integration later? |
…ce we can just use pubsub discovery
aschmahmann
force-pushed
the
feat/discovery
branch
from
e6a6cc9
to
4c1aadd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that PubSub has an optional discovery service built into it seems reasonable for the PubsubValueStore to assume that the PubSub instance passed into it utilizes this discovery mechanism (if that is in fact what the caller intends). This closes #28.
While we're doing breaking the constructor and semantics anyway (removing the mandatory ContentRouter and needing the PubSub instance passed in to have Discovery enabled) I also added an option pattern to the constructor.