feat: update pubsub #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/update-pubsub
branch
from
9ddfbc5
to
9b71968
Compare
|
(merging pre-review so I can bubble this to go-ipfs) |
aschmahmann
approved these changes
May 21, 2020
Comment on lines
+196
to
+198
| if !valid { | ||
| return pubsub.ValidationReject | ||
| } |
There was a problem hiding this comment.
This seems fine are we using the scoring function at all? What do you think about rejecting cmp < 0 as well? This should mean peers will occasionally get published, but should not get punished repeatedly. I don't know how long it takes to recover score after being penalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.