Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new stream interfaces from go-libp2p-core 0.7.0 #81

Merged
merged 1 commit into from
Nov 12, 2020
Merged

feat: use new stream interfaces from go-libp2p-core 0.7.0 #81

merged 1 commit into from
Nov 12, 2020

Conversation

Stebalien
Copy link
Member

This was referenced Nov 2, 2020
Merged
Merged
aschmahmann
aschmahmann approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a minor suggestion that's mostly my fault from when I implemented this

fetch.go Show resolved Hide resolved
@Stebalien Stebalien merged commit fe35a3c into master Nov 12, 2020
@Stebalien Stebalien deleted the feat/rw-close branch November 12, 2020 17:13
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @aschmahmann