-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faulty peer disconnection notification logic #130
Comments
Also of note that the peer connection event is emitted twice as well. |
related: #117 |
Upon reflection, the issue here is that our peer management is completely incapable of handling multiple connections to the same peer. We will need to completely rework on peer management logic it seems. |
cc @cheatfate |
Source issue confirmed as fixed by @cheatfate; closing. |
If there are multiple connections to the same peer, then the disconnect notification is emitted even though the peer is still connected, breaking gossipsub's peer tracking.
See the logs in vacp2p/nim-libp2p#8
The text was updated successfully, but these errors were encountered: