Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the peer that propagates a message to the recipient #218

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Oct 18, 2019

This is a solution for #215. We were doing a lot of passing around (src, Message) to avoid exposing the source next to the message, so I hope that solving #215 is a good thing 😬.

I haven't removed all the places where we pass both src and Message, but got most of the internal ones.

Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a pretty good rationalisation to me anyway, even if we didn't have to address #218.

go.mod Show resolved Hide resolved
pubsub.go Outdated Show resolved Hide resolved
@raulk
Copy link
Member

raulk commented Oct 18, 2019

Let's wait for @vyzo to sign-off too.

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyzo
Copy link
Collaborator

vyzo commented Oct 18, 2019

Test failure is systemic, @aschmahmann you need to go fmt!

*** go fmt ./...

ERROR: some files not gofmt'ed:

./floodsub_test.go

@aschmahmann
Copy link
Contributor Author

@aschmahmann you need to go fmt!

lol that's what I get for trying to rename a variable using the Github text editor

@vyzo vyzo merged commit aa9a875 into master Oct 18, 2019
@vyzo vyzo deleted the feat/view-last-hop branch October 18, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants