Publishing option for signing a message with a custom private key #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
May 25, 2022
•
iulianpascalau
commented
- added publishing option for signing a message with a custom private key
vyzo
reviewed
May 25, 2022
vyzo
reviewed
May 25, 2022
topic.go
Outdated
| // (which can be cached) will improve the performance as it does not require the generation of the public key | ||
| // and the resulting peer ID. | ||
| // This method can be used as to be able to publish messages on the network without having a "real", connectable host. | ||
| func (t *Topic) PublishWithSk(ctx context.Context, data []byte, signKey crypto.PrivKey, pid peer.ID, opts ...PubOpt) error { |
There was a problem hiding this comment.
let's not abbreviate the Sk and say PublishWithKey or PublishWithSecretKey.
There was a problem hiding this comment.
will refactor
I will explore that. I was on the verge of pushing a new commit for code duplication removal. |
iulianpascalau
changed the title
iulianpascalau
changed the title
vyzo
requested changes
May 26, 2022
vyzo
reviewed
May 26, 2022
topic_test.go
Outdated
| @@ -920,3 +921,101 @@ func TestWithTopicMsgIdFunction(t *testing.T) { | |||
| t.Fatal("msg ids are equal") | |||
| } | |||
| } | |||
|
|
|||
| func TestTopic_PublishWithKeyInvalidParameters(t *testing.T) { | |||
There was a problem hiding this comment.
can we remove the underscore?
There was a problem hiding this comment.
this is the Elrond pattern used in tests :)
topic_test.go
Outdated
| }) | ||
| } | ||
|
|
||
| func TestTopicRelay_PublishWithKey(t *testing.T) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.