Improve handling of dead peers #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
requested changes
Nov 20, 2022
Wondertan
force-pushed
the
improve-dead-peer-handling
branch
from
c1dedb4
to
62ed3a6
Compare
Wondertan
force-pushed
the
improve-dead-peer-handling
branch
from
62ed3a6
to
58c3893
Compare
|
Ohh, right, fixed |
vyzo
approved these changes
Nov 20, 2022
|
I'd like to cut a patch release with these patches, can you do some sanity testing before I fo so? |
|
All the tests pass locally, or what do you mean? |
|
Run a canary node in production for a day or two? |
|
@vyzo, Ok. I started my lotus daemon and miner on pubsub's master with the recent changes. I will report back on how it is going in a few days. It should give us enough confidence |
yhassanzadeh13
added a commit
to yhassanzadeh13/go-libp2p-pubsub
that referenced
this pull request
Nov 24, 2022
* perf: use msgio pooled buffers for received msgs (libp2p#500) * perf: use pooled buffers for message writes (libp2p#507) * improve handling of dead peers (libp2p#508) * chore: ignore signing keys during WithLocalPublication publishing (libp2p#497) * adds app specific rpc handler Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com> Co-authored-by: Viacheslav <viacheslavgonkivskyi@gmail.com>
|
@vyzo, 5 days of stable sync - |
|
altight, i'll tag a release on momday. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #506