This repository has been archived by the owner on May 26, 2022. It is now read-only.
accept a PSK in the transport constructor (and reject it) #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
Stebalien
approved these changes
Feb 27, 2020
Stebalien
reviewed
Mar 7, 2020
| func NewTransport(key ic.PrivKey) (tpt.Transport, error) { | ||
| func NewTransport(key ic.PrivKey, psk pnet.PSK) (tpt.Transport, error) { | ||
| if len(psk) > 0 { | ||
| log.Error("QUIC doesn't support private networks yet.") |
There was a problem hiding this comment.
Note: when we actually implement this, let's derive a new shared secret by hashing "quic-pnet" + PSK.
There was a problem hiding this comment.
@Stebalien I've proposed to use a HKDF for that in libp2p/specs#250
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't construct a QUIC transport if a PSK is provided, since QUIC doesn't provide private network support yet (see libp2p/go-libp2p#1432).
This PR mainly serves to demonstrate how we'd use the new
ipnet.PSKfor QUIC.Tracking issue: libp2p/go-libp2p#795.