This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Move Config and ACL to the top-level module #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would like to programatically generate relays configurations, however this is slightly more difficult because, despite being exported types, they are in the "main" package. This PR moves them to the top-level directory so that they can be imported from other modules. I also took the liberty of documenting things.
|
@lidel : tagging you as owner of the repo ? |
marten-seemann
approved these changes
Jul 24, 2022
Merged
TheDiscordian
pushed a commit
to TheDiscordian/go-libp2p-relay-daemon
that referenced
this pull request
Oct 4, 2022
I would like to programatically generate relays configurations, however this is slightly more difficult because, despite being exported types, they are in the "main" package. This PR moves them to the top-level directory so that they can be imported from other modules. I also took the liberty of documenting things.
TheDiscordian
pushed a commit
to TheDiscordian/go-libp2p-relay-daemon
that referenced
this pull request
Oct 4, 2022
I would like to programatically generate relays configurations, however this is slightly more difficult because, despite being exported types, they are in the "main" package. This PR moves them to the top-level directory so that they can be imported from other modules. I also took the liberty of documenting things.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to programatically generate relays configurations, however this
is slightly more difficult because, despite being exported types, they are in
the "main" package.
This PR moves them to the top-level directory so that they can be imported from
other modules.
I also took the liberty of documenting things.