Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

More documentation around limits #68

Closed
MarcoPolo opened this issue Jul 7, 2022 · 2 comments · Fixed by #75
Closed

More documentation around limits #68

MarcoPolo opened this issue Jul 7, 2022 · 2 comments · Fixed by #75
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MarcoPolo
Copy link
Contributor

This should cover @BigLep's questions here: #59 (review).

  1. How to bypass limits
  2. What are the default limits if I do nothing when constructing a ResourceManager (or even better as a user am I always forced to set a Limiter when constructing a ResourceManager thus need to think about this).
  3. If I do always have to create a Limiter, is there a base LimitConfig I can use (and where is it)?
  4. What does the code look like if I like everything about a base LimitConfig but then want to override one specific part of it.

And address the question here: #59 (comment)

It would be best if the documentation included testable examples

@MarcoPolo MarcoPolo added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Jul 7, 2022
@BigLep
Copy link
Contributor

BigLep commented Aug 7, 2022

There were questions in https://www.notion.so/pl-strflt/Guide-for-how-to-respond-to-resource-exhaustion-attacks-b10f55cc9a3d4917ae80c9b914e05e8c#f5d6b23e93d84946be400466f7560628 that may also be relevant:

What are the consequences of enabling tight resource limits?
What connections are getting killed?
What kind of errors will I see?
Does resource limiting make make a difference between honest peers and bad peers?

@MarcoPolo
Copy link
Contributor Author

A lot of this is covered in PR #75

@MarcoPolo MarcoPolo linked a pull request Aug 8, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants