Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Add package docs #75

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Add package docs #75

merged 5 commits into from
Aug 11, 2022

Conversation

MarcoPolo
Copy link
Contributor

Adds some package docs that will show up in the godoc page. Inspired by the formatting of https://pkg.go.dev/encoding/gob.

@MarcoPolo MarcoPolo linked an issue Aug 8, 2022 that may be closed by this pull request
@MarcoPolo
Copy link
Contributor Author

Coming back to this, I think this makes more sense to live in the README. So I'm thinking I should merge this information into the existing information in the readme and add a table of contents at the top of the readme, and adjust the ordering so usage comes first.

Wdyt @marten-seemann ?

@BigLep BigLep self-requested a review August 9, 2022 05:10
@BigLep
Copy link
Contributor

BigLep commented Aug 9, 2022

@MarcoPolo : I know you weren't asking me, but your plan seems reasonable to me.
I'll wait to review the text until we have the merged readme.
I assume go docs will link to the readme for more info so it's easily discoverable when someone's looking at the go docs?

@MarcoPolo
Copy link
Contributor Author

updated @marten-seemann

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

These errors occur whenever we've hit a limit. For example we'll get this error
if we are at our limit for the number of streams we can have, and we try to open
one more.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency between "you" in the other paragraphs and the "we" here. Maybe it's better to use passive voice here: "These errors occur whenever a limit is hit."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the passive voice for the first sentence, then you for the rest of the paragraph.

@MarcoPolo MarcoPolo merged commit 2692b75 into master Aug 11, 2022
@MarcoPolo MarcoPolo deleted the marco/docs branch August 11, 2022 01:19
BigLep added a commit that referenced this pull request Aug 11, 2022
Typos and adjustments that missed getting into #75
@BigLep BigLep mentioned this pull request Aug 11, 2022
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More documentation around limits
3 participants