This repository has been archived by the owner on May 26, 2022. It is now read-only.
ID() method on connections and streams + record opening time
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
Jorropo
pushed a commit
to Jorropo/go-libp2p-swarm
that referenced
this pull request
Oct 8, 2020
…p#224) Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com> Co-authored-by: Raúl Kripalani <raul@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the interface change introduced in
network.Connandnetwork.Streamby libp2p/go-libp2p-core#159, concretely it adds anID() stringmethod that returns increasing ordinal IDs that are unique within the current host run:Conn#ID()returns a string of format<peerid[0:10]>-<unique, incrementing ordinal>.Stream#ID()returns a string of format<conn_id-<unique, incrementing ordinal>.This change also starts recording the opening timestamp of connections and streams under
network.Stat.Follows on from #204 after heavy modifications of the original proposal.