This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
feat: catch panics in TLS negotiation #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,7 +74,15 @@ func (i *Identity) ConfigForPeer(remote peer.ID) (*tls.Config, <-chan ic.PubKey) | |||
| conf := i.config.Clone() | |||
| // We're using InsecureSkipVerify, so the verifiedChains parameter will always be empty. | |||
| // We need to parse the certificates ourselves from the raw certs. | |||
| conf.VerifyPeerCertificate = func(rawCerts [][]byte, _ [][]*x509.Certificate) error { | |||
| conf.VerifyPeerCertificate = func(rawCerts [][]byte, _ [][]*x509.Certificate) (err error) { | |||
There was a problem hiding this comment.
This is not needed, since we have the panic handler in handshake, is it?
There was a problem hiding this comment.
- This way we don't panic through TLS (not sure what that might do).
- E.g., I don't trust that TLS won't run this on another goroutine.
There was a problem hiding this comment.
crypto/tls doesn't, but we can leave it here to be extra paranoid.
marten-seemann
approved these changes
Apr 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of libp2p/go-libp2p#1389