This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
make the error check for not receiving a public key more explicit #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
suggested changes
Aug 1, 2019
| @@ -104,6 +104,7 @@ func (t *Transport) handshake( | |||
| select { | |||
| case remotePubKey = <-keyCh: | |||
| default: | |||
| return nil, errors.New("go-libp2p-tls BUG: expected remote pub key to be set") | |||
There was a problem hiding this comment.
This previously implicitly checked if the channel was closed before returning a key. We still need to check that.
There was a problem hiding this comment.
Thanks for catching this. Using a chan to return the key seems a bit error-prone...
marten-seemann
force-pushed
the
no-key-error-check
branch
from
699dbc0
to
27e03a0
Compare
Stebalien
approved these changes
Aug 26, 2019
This was referenced Jan 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.