This repository has been archived by the owner on May 26, 2022. It is now read-only.
reduce the number of max incoming stream to 256 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-yamux sets a default of 1000.
vyzo
approved these changes
Dec 10, 2021
|
Tests are failing because there's a test that's opening 1000 streams. This test is valuable for QUIC, which has proper stream management, but of course it fails with subpar stream muxers such as yamux. |
marten-seemann
force-pushed
the
reduce-streams
branch
from
63f8da0
to
3b81f16
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-yamux sets a default of 1000.
Depends on libp2p/go-libp2p-testing#41.