Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more context wiring #106

Closed
whyrusleeping opened this issue Sep 6, 2016 · 1 comment
Closed

more context wiring #106

whyrusleeping opened this issue Sep 6, 2016 · 1 comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@whyrusleeping
Copy link
Contributor

There are many different long running calls that we don't pass contexts into, for example, the IdentifyConn call in p2p/protocol/identify. We should make an effort to have contexts wired throughout the entire codebase
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
@ghost ghost added status/deferred Conscious decision to pause or backlog and removed status/deferred Conscious decision to pause or backlog labels Nov 12, 2016
@Kubuxu Kubuxu added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
@bigs bigs added exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Sep 11, 2018
@Stebalien
Copy link
Member

We now:

  1. Run identify on every conn automatically.
  2. Provide an IdentifyWait(conn) <-chan struct{} to wait for this to finish.

We've also threaded contexts through to stream creation, so I think we're good.

marten-seemann pushed a commit that referenced this issue Apr 22, 2022
@web3-bot
sync: update CI config files (#106)
9647169
marten-seemann added a commit that referenced this issue Apr 27, 2022
@marten-seemann
use tls.Conn.HandshakeContext instead of tls.Conn.Handshake (#106)
7ee67dd 
* use tls.Conn.HandshakeContext instead of tls.Conn.Handshake

* make sure that crypto/tls picks up the handshake ctx cancelation in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bigs @Stebalien @daviddias @whyrusleeping @Kubuxu