Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocknet flaky under stress #32

Closed
whyrusleeping opened this issue Apr 5, 2016 · 2 comments
Closed

mocknet flaky under stress #32

whyrusleeping opened this issue Apr 5, 2016 · 2 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@whyrusleeping
Copy link
Contributor

I beleive there is a bug in the mocknet hosts somewhere. When putting it under stress i get strange failures (messages appear to go places they arent wanted). Switching to using testnet tcp backed hosts fixes the problems.

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
@ghost ghost added status/deferred Conscious decision to pause or backlog and removed status/deferred Conscious decision to pause or backlog labels Nov 12, 2016
@whyrusleeping whyrusleeping added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
@daviddias daviddias added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important labels Aug 19, 2017
@anacrolix
Copy link
Contributor

Are there unit tests or CIs that you can refer to us?

@Stebalien
Copy link
Member

Hm. We should probably just close this. We've fixed a bunch of connectivity, race, etc. issues since this was filed.

@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Feb 20, 2019
@Stebalien Stebalien mentioned this issue May 11, 2021
27 tasks
marten-seemann pushed a commit that referenced this issue Dec 20, 2021
* limits addresses for a peer (at most 4 chosen) - fix #39
* clears addresses before dialing back - fix #38
* global rate limit of 30 responses per (1 - 1.25 min) - fix #36
* only dial back on the source IP - fix #32
marten-seemann added a commit that referenced this issue Apr 22, 2022
marten-seemann pushed a commit that referenced this issue Apr 27, 2022
remove key serialization, construct conn from ipnet.PSK
marten-seemann pushed a commit that referenced this issue May 18, 2022
Defer closing stream for reading
marten-seemann pushed a commit that referenced this issue Jul 1, 2022
avoid putting nil multadders in the PeerInfo
marten-seemann pushed a commit that referenced this issue Aug 9, 2022
* Introduce tests for KeyBook to increase coverage.
* Change usages of []peer.ID to IDSlice, which supports sorting.
* Restructure AddrBook tests into subtests.
* Import aliases.
marten-seemann pushed a commit that referenced this issue Aug 17, 2022
Replace bytes.Equal -> subtle.ConstantTimeCompare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

4 participants