Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in mock_conn #533

Closed
iulianpascalau opened this issue Feb 14, 2019 · 3 comments
Closed

Race condition in mock_conn #533

iulianpascalau opened this issue Feb 14, 2019 · 3 comments

Comments

@iulianpascalau
Copy link

Hello

I think I have found a race condition in mock_conn.go, function GetStreams.
A c.RLock() - c.RUnlock() pair is missing.
And by the way, wasn't suppose to call allStreams as the funcs basically do the same thing.

Thanks
@iulianpascalau iulianpascalau mentioned this issue Feb 14, 2019
Merged
@raulk
Copy link
Member

raulk commented Feb 14, 2019

Hey, thanks for the report. Would you mind submitting a PR?

@iulianpascalau
Copy link
Author

iulianpascalau commented Feb 14, 2019 •
edited
Loading

Will do the PR.

@iulianpascalau
Copy link
Author

PR created #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raulk @iulianpascalau