Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed race conditions in mock package mock_stream and mock_conn #535

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fixed race conditions in mock package mock_stream and mock_conn #535

merged 1 commit into from
Feb 14, 2019

Conversation

iulianpascalau
Copy link

  • changed GetStreams function from mock_conn.go to call allStreams which has the same functionality but is concurrent safe
  • changed protocol field from mock_stream to be concurrent safe. Taken the implementation from swarm_stream.go

mock package:
b8e47c5 
- changed GetStreams function from mock_conn.go to call allStreams which has the same functionality but is concurrent safe
- changed protocol field from mock_stream to be concurrent safe. Taken the implementation from swarm_stream.go
@iulianpascalau iulianpascalau mentioned this pull request Feb 14, 2019
Closed
@iulianpascalau iulianpascalau changed the title mock package: Fixed race conditions in mock package mock_stream and mock_conn Feb 14, 2019
@Stebalien Stebalien merged commit 74b74b1 into libp2p:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iulianpascalau @Stebalien