Improve swarm dial sync code #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
added
status/in-progress
whyrusleeping
force-pushed
the
feat/better-dialsync
branch
from
77f2352
to
126e150
Compare
|
@lgierth @Kubuxu Could I get some review here? maybe even some from @diasdavid :D |
|
LGTM |
|
This is pretty cool :D |
marten-seemann
pushed a commit
that referenced
this pull request
Jul 1, 2022
fix: don't abort accept when accepting a single connection fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous dialsync code was susceptible to the issue described in #105
This fixes that and adds some tests around the whole thing