-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps #1141
chore: update deps #1141
Conversation
8d32b9c
to
0b15f03
Compare
We're in a dependency loop here. For the interop tests, we need to update go-libp2p-daemon, which depends on go-ipns, which depends on go-libp2p-kad-dht, which in turn depends on go-libp2p. Due to the deprecations, we will have to update go-libp2p in go-libp2p-kad-dht first, but we need to cut a go-libp2p for that, and we can't do that without merging this PR. We could just merge this PR and ignore CI, but this is quite an annoying situation. |
0b15f03
to
63e0043
Compare
We use replace directives here so we shouldn't need to do that. Instead, I think we need to release versions of ipns/pubsub that don't use deprecated interfaces (those patches have been merged) and merge those into the libp2p daemon. We don't even need to release the daemon. If that's not enough, we can introduce "next" branches (where these tests checkout "next" branches if they exist upstream). I though I did that, but I guess I reverted that change (probably to simplify for now). |
Unfortunately, I already release go-ipns v0.1.1 that also updates the dependencies. |
63e0043
to
1ca22ac
Compare
The go-ipns dep needs to be updated in go-libp2p-daemon. I really don't want to merge this without fixing CI. We introduced these checks so we could catch issues with large updates. |
So... we're going to need to retract all of those breaking patch releases. |
0efe596
to
d9e6b61
Compare
Ok, we just cut new patch releases. Everything should be fixed now. We should do a mini-retro; we don't have a foot-gun here, we have a minefield. |
144a335
to
8160df3
Compare
8160df3
to
366bdea
Compare
This should conclude our deprecation party (for now): go-libp2p now builds with both go-libp2p-core and go-multiaddr updated (which were the two packages where we removed a bunch of deprecated types / functions).