Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #1141

Merged
merged 1 commit into from
Aug 2, 2021
Merged

chore: update deps #1141

merged 1 commit into from
Aug 2, 2021

Conversation

marten-seemann
Copy link
Contributor

This should conclude our deprecation party (for now): go-libp2p now builds with both go-libp2p-core and go-multiaddr updated (which were the two packages where we removed a bunch of deprecated types / functions).

@marten-seemann
Copy link
Contributor Author

We're in a dependency loop here. For the interop tests, we need to update go-libp2p-daemon, which depends on go-ipns, which depends on go-libp2p-kad-dht, which in turn depends on go-libp2p. Due to the deprecations, we will have to update go-libp2p in go-libp2p-kad-dht first, but we need to cut a go-libp2p for that, and we can't do that without merging this PR.

We could just merge this PR and ignore CI, but this is quite an annoying situation.

@Stebalien
Copy link
Member

We're in a dependency loop here. For the interop tests, we need to update go-libp2p-daemon, which depends on go-ipns, which depends on go-libp2p-kad-dht, which in turn depends on go-libp2p. Due to the deprecations, we will have to update go-libp2p in go-libp2p-kad-dht first, but we need to cut a go-libp2p for that, and we can't do that without merging this PR.

We use replace directives here so we shouldn't need to do that.

Instead, I think we need to release versions of ipns/pubsub that don't use deprecated interfaces (those patches have been merged) and merge those into the libp2p daemon. We don't even need to release the daemon.

If that's not enough, we can introduce "next" branches (where these tests checkout "next" branches if they exist upstream). I though I did that, but I guess I reverted that change (probably to simplify for now).

@marten-seemann
Copy link
Contributor Author

Instead, I think we need to release versions of ipns/pubsub that don't use deprecated interfaces (those patches have been merged) and merge those into the libp2p daemon.

Unfortunately, I already release go-ipns v0.1.1 that also updates the dependencies.
I suggest disabling the interop workflow for now, until the loop has been resolved.

@Stebalien
Copy link
Member

The go-ipns dep needs to be updated in go-libp2p-daemon. I really don't want to merge this without fixing CI. We introduced these checks so we could catch issues with large updates.

@Stebalien
Copy link
Member

So... we're going to need to retract all of those breaking patch releases.

@Stebalien Stebalien force-pushed the update-deps branch 4 times, most recently from 0efe596 to d9e6b61 Compare July 28, 2021 06:28
@Stebalien
Copy link
Member

Ok, we just cut new patch releases. Everything should be fixed now.

We should do a mini-retro; we don't have a foot-gun here, we have a minefield.

@marten-seemann marten-seemann force-pushed the update-deps branch 3 times, most recently from 144a335 to 8160df3 Compare July 28, 2021 12:25
@Stebalien Stebalien merged commit 93ad759 into master Aug 2, 2021
@Stebalien Stebalien deleted the update-deps branch August 2, 2021 15:34
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants