connmgr: add nowatchdog go build tag #1666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to disable watchdog even if cgo is enabled.
I logicaly tested the configuration using a truth table to cover each case:
Where:
p
:cgo
tagq
:nowatchdog
tagp∧¬q
:watchdog_cgo.go
compiled iftrue
¬p∨q
:watchdog_no_cgo.go
compiled iftrue
(p∧¬q)⊕(¬p∨q)
: only one of these files is compiled iftrue
Usage (for newbies)
$ go build -tags nowatchdog .
Additionnal note
This fixes an old problem I reported a few months ago: libp2p/go-libp2p-connmgr#98.
I couldn't find a convention to write a deactivation tag, so I added the
no
prefix towatchdog
but if you have a better proposal you're welcome.