Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: use ALPN to negotiate the stream multiplexer #1772

Merged
merged 17 commits into from
Oct 7, 2022
Merged

tls: use ALPN to negotiate the stream multiplexer #1772

merged 17 commits into from
Oct 7, 2022

Conversation

julian88110
Copy link
Contributor

@julian88110 julian88110 commented Sep 21, 2022 •
edited
Loading

Tracked by #1751
This is an implementation of TLS based muxer selection proposed in #426 and specified in spec #446

@julian88110 julian88110 marked this pull request as ready for review September 27, 2022 16:41
marten-seemann
marten-seemann reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this touches a lot less files than the previous iteration!

p2p/muxer/muxer-multistream/multistream.go Show resolved Hide resolved
p2p/net/upgrader/upgrader.go Outdated Show resolved Hide resolved
p2p/security/tls/transport.go Outdated Show resolved Hide resolved
p2p/security/tls/transport.go Outdated Show resolved Hide resolved
p2p/security/tls/transport_test.go Outdated Show resolved Hide resolved
p2p/security/tls/transport_test.go Outdated Show resolved Hide resolved
core/network/conn.go Outdated Show resolved Hide resolved
config/constructor_types.go Outdated Show resolved Hide resolved
p2p/muxer/muxer-multistream/multistream.go Outdated Show resolved Hide resolved
p2p/net/upgrader/upgrader.go Outdated Show resolved Hide resolved
julian88110 and others added 2 commits September 28, 2022 10:26
@julian88110
Address feedback points
ec0a96c
@julian88110 @marten-seemann
Update p2p/net/upgrader/upgrader.go
8cf8183 
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
marten-seemann reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. A couple of nits, mostly Go stylistic stuff.

config/security.go Outdated Show resolved Hide resolved
core/network/conn.go Outdated Show resolved Hide resolved
p2p/net/upgrader/upgrader.go Outdated Show resolved Hide resolved
p2p/net/upgrader/upgrader.go Outdated Show resolved Hide resolved
p2p/security/noise/session.go Outdated Show resolved Hide resolved
p2p/security/tls/transport.go Show resolved Hide resolved
p2p/security/tls/transport_test.go Outdated Show resolved Hide resolved
p2p/security/tls/transport_test.go Outdated Show resolved Hide resolved
p2p/security/tls/transport_test.go Outdated Show resolved Hide resolved
p2p/security/tls/transport_test.go Outdated Show resolved Hide resolved
@julian88110 julian88110 self-assigned this Sep 29, 2022
This was referenced Sep 30, 2022
Closed
Closed
@marten-seemann marten-seemann changed the title Tls mux sel tls: use ALPN to negotiate the stream multiplexer Sep 30, 2022
marten-seemann
marten-seemann reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 super tiny nits, then we should be good to go!

p2p/security/tls/transport.go Show resolved Hide resolved
p2p/security/tls/transport.go Outdated Show resolved Hide resolved
p2p/security/tls/transport_test.go Outdated Show resolved Hide resolved
marten-seemann
marten-seemann reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super minor nit in the test, then this should be good to go.

p2p/security/tls/transport_test.go Outdated Show resolved Hide resolved
@julian88110 julian88110 merged commit ebd000d into master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@MarcoPolo MarcoPolo Awaiting requested review from MarcoPolo

Assignees

@julian88110 julian88110

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julian88110 @marten-seemann