Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm / rcmgr: synchronize the concurrent outbound dials with limits #1898

Merged
merged 2 commits into from
Nov 22, 2022
Merged

swarm / rcmgr: synchronize the concurrent outbound dials with limits #1898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef3657
Synchronize the concurrent outbound dials with limits
MarcoPolo Nov 17, 2022
5c8f737
Add comment
MarcoPolo Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion p2p/host/resource-manager/limit_defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,10 @@ var DefaultLimits = ScalingLimitConfig{
},

PeerBaseLimit: BaseLimit{
ConnsInbound: 4,
// 8 for now so that it matches the number of concurrent dials we may do
// in swarm_dial.go. With future smart dialing work we should bring this
// down
ConnsInbound: 8,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why this is 8 for now, and that smart dialing will allow us to reduce this back to 4?

ConnsOutbound: 8,
Conns: 8,
StreamsInbound: 256,
Expand Down