chore: update go-netroute so that we get the correct priority of routes #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the go-netroute dependency to get this fix: https://github.com/libp2p/go-netroute/pull/26/files.
Fixes #1849
The sorting of priorities was wrong/incomplete, so we would return the wrong interface to dial out. When a VPN is setup like wireguard, the VPN interface should have higher priority (well technically a smaller number). If we don't check this priority we could try to use the non-VPN interface to dial out and that would fail since the host probably has rules to prevent any packets not sent out over the VPN (to avoid leaks).
By bringing in this fix, we check the priority properly and use the correct (VPN) interface to dial out.