quic / webtransport: make it possible to listen on the same address / port #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
shared-quic-webtransport-port
branch
from
75224e3 to
a2fa1e5
Compare
MarcoPolo
reviewed
Nov 22, 2022
| if cfg.QUICReuse != nil { | ||
| fxopts = append(fxopts, cfg.QUICReuse...) | ||
| } else { | ||
| fxopts = append(fxopts, fx.Provide(quicreuse.NewConnManager)) // TODO: close the ConnManager when shutting down the node |
There was a problem hiding this comment.
Do we still need this todo?
MarcoPolo
requested changes
Nov 22, 2022
DecreaseCount now closes the underlying UDP conn, so that callers don't need to pay attention if they're dealing with a reuseConn or a noreuseConn.
MarcoPolo
force-pushed
the
shared-quic-webtransport-port
branch
from
a2fa1e5 to
ddd4855
Compare
MarcoPolo
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1759. Depends on #1895. Depends on quic-go/webtransport-go#47.
Also adds an integration test for QUIC version support.