Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holepunch: fix flaky test by not removing holepunch protocol handler #1948

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

marten-seemann
Copy link
Contributor

Fixes #1943.

@marten-seemann marten-seemann changed the title holepunch: fix flaky test by waiting for holepunch protocol to be set holepunch: fix flaky by not remove holepunch protocol handler Dec 12, 2022
@marten-seemann marten-seemann changed the title holepunch: fix flaky by not remove holepunch protocol handler holepunch: fix flaky test by not removing holepunch protocol handler Dec 23, 2022
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this only fails if rhandler is the first thing in the iteration. And since it's a map it's random order of iteration...

This is an example on why you should prefer a list over a map for test cases.

@marten-seemann marten-seemann merged commit 6ebdb17 into master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

holepunch: flaky TestFailuresOnInitiator
2 participants