Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autorelay: Refactor relay_finder and start autorelay after identify #2120

Merged
merged 7 commits into from
Feb 23, 2023

Conversation

MarcoPolo
Copy link
Collaborator

Fixes two flaky issues:

  1. autrelay may start making connections before the identify goroutines are ready.
  2. autorelay_tests are flaky because the ticker channels may be received in the wrong order.

Also uses a fork of the mock clock library to fix a data race in the library. Upstream patch coming soon.

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot cleaner than what we had. Some suggestions to make it even cleaner.

go.mod Outdated Show resolved Hide resolved
p2p/host/autorelay/autorelay_test.go Show resolved Hide resolved
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
@marten-seemann marten-seemann mentioned this pull request Feb 22, 2023
25 tasks
@MarcoPolo MarcoPolo requested review from marten-seemann and removed request for marten-seemann February 23, 2023 01:37
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
p2p/host/autorelay/relay_finder.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants