-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial prototype of http over libp2p #2218
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,146 @@ | ||
package p2phttp | ||
|
||
import ( | ||
"bufio" | ||
"fmt" | ||
"io" | ||
"net/http" | ||
"strconv" | ||
"sync" | ||
|
||
logging "github.com/ipfs/go-log/v2" | ||
) | ||
|
||
var bufWriterPool = sync.Pool{ | ||
New: func() any { | ||
return bufio.NewWriterSize(nil, 4<<10) | ||
}, | ||
} | ||
|
||
var bufReaderPool = sync.Pool{ | ||
New: func() any { | ||
return bufio.NewReaderSize(nil, 4<<10) | ||
}, | ||
} | ||
|
||
var log = logging.Logger("p2phttp") | ||
|
||
var _ http.ResponseWriter = (*httpResponseWriter)(nil) | ||
|
||
type httpResponseWriter struct { | ||
w *bufio.Writer | ||
directWriter io.Writer | ||
header http.Header | ||
wroteHeader bool | ||
inferredContentLength bool | ||
} | ||
|
||
// Header implements http.ResponseWriter | ||
func (w *httpResponseWriter) Header() http.Header { | ||
return w.header | ||
} | ||
|
||
// Write implements http.ResponseWriter | ||
func (w *httpResponseWriter) Write(b []byte) (int, error) { | ||
if !w.wroteHeader { | ||
if w.header.Get("Content-Type") == "" { | ||
contentType := http.DetectContentType(b) | ||
w.header.Set("Content-Type", contentType) | ||
} | ||
|
||
if w.w.Available() > len(b) { | ||
return w.w.Write(b) | ||
} | ||
} | ||
|
||
// Ran out of buffered space, We should check if we need to write the headers. | ||
if !w.wroteHeader { | ||
// Be nice for small things | ||
if w.header.Get("Content-Length") == "" { | ||
w.inferredContentLength = true | ||
w.header.Set("Content-Length", strconv.Itoa(len(b)+w.w.Buffered())) | ||
MarcoPolo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
// If WriteHeader has not yet been called, Write calls | ||
// WriteHeader(http.StatusOK) before writing the data. | ||
w.WriteHeader(http.StatusOK) | ||
} | ||
|
||
if w.inferredContentLength { | ||
log.Error("Tried to infer content length, but another write happened, so content length is wrong and headers are already written. This response may fail to parse by clients") | ||
} | ||
|
||
return w.w.Write(b) | ||
} | ||
|
||
func (w *httpResponseWriter) flush() { | ||
if !w.wroteHeader { | ||
// Be nice for small things | ||
if w.header.Get("Content-Length") == "" { | ||
w.inferredContentLength = true | ||
w.header.Set("Content-Length", strconv.Itoa(w.w.Buffered())) | ||
} | ||
|
||
// If WriteHeader has not yet been called, Write calls | ||
// WriteHeader(http.StatusOK) before writing the data. | ||
w.WriteHeader(http.StatusOK) | ||
w.w.Flush() | ||
} | ||
} | ||
|
||
// WriteHeader implements http.ResponseWriter | ||
func (w *httpResponseWriter) WriteHeader(statusCode int) { | ||
if w.wroteHeader { | ||
log.Errorf("multiple WriteHeader calls dropping %d", statusCode) | ||
return | ||
} | ||
w.wroteHeader = true | ||
w.writeStatusLine(statusCode) | ||
w.header.Write(w.directWriter) | ||
w.directWriter.Write([]byte("\r\n")) | ||
} | ||
|
||
// Copied from Go stdlib https://cs.opensource.google/go/go/+/refs/tags/go1.20.2:src/net/http/server.go;drc=ea4631cc0cf301c824bd665a7980c13289ab5c9d;l=1533 | ||
func (w *httpResponseWriter) writeStatusLine(code int) { | ||
MarcoPolo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// Stack allocated | ||
scratch := [4]byte{} | ||
// Always HTTP/1.1 | ||
w.directWriter.Write([]byte("HTTP/1.1 ")) | ||
|
||
if text := http.StatusText(code); text != "" { | ||
w.directWriter.Write(strconv.AppendInt(scratch[:0], int64(code), 10)) | ||
w.directWriter.Write([]byte(" ")) | ||
w.directWriter.Write([]byte(text)) | ||
w.directWriter.Write([]byte("\r\n")) | ||
} else { | ||
// don't worry about performance | ||
fmt.Fprintf(w.directWriter, "%03d status code %d\r\n", code, code) | ||
} | ||
} | ||
|
||
func ServeReadWriter(rw io.ReadWriter, handler http.Handler) { | ||
r := bufReaderPool.Get().(*bufio.Reader) | ||
r.Reset(rw) | ||
defer bufReaderPool.Put(r) | ||
|
||
buffedWriter := bufWriterPool.Get().(*bufio.Writer) | ||
buffedWriter.Reset(rw) | ||
defer bufWriterPool.Put(buffedWriter) | ||
w := httpResponseWriter{ | ||
w: buffedWriter, | ||
directWriter: rw, | ||
header: make(http.Header), | ||
} | ||
defer w.w.Flush() | ||
|
||
req, err := http.ReadRequest(r) | ||
if err != nil { | ||
w.WriteHeader(http.StatusBadRequest) | ||
w.w.Flush() | ||
log.Errorf("error reading request: %s", err) | ||
return | ||
} | ||
|
||
handler.ServeHTTP(&w, req) | ||
w.flush() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
package p2phttp | ||
|
||
import ( | ||
"bufio" | ||
"bytes" | ||
"fmt" | ||
"net/http" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestResponseLooksCorrect(t *testing.T) { | ||
req, err := http.NewRequest("GET", "http://localhost/", bytes.NewReader([]byte(""))) | ||
require.NoError(t, err) | ||
reqBuf := bytes.Buffer{} | ||
req.Write(&reqBuf) | ||
|
||
resp := bytes.Buffer{} | ||
respWriter := bufio.NewWriter(&resp) | ||
s := bufio.NewReadWriter(bufio.NewReader(&reqBuf), respWriter) | ||
|
||
ServeReadWriter(s, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
w.Write([]byte("Hello world")) | ||
})) | ||
|
||
respWriter.Flush() | ||
fmt.Println("Resp is", resp.String()) | ||
parsedResponse, err := http.ReadResponse(bufio.NewReader(&resp), nil) | ||
require.NoError(t, err) | ||
fmt.Println("Parsed response is", parsedResponse) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably doesn't matter (and definitely not for a prototype): What about creating a new reader / writer, but taking the underlying the byte slice from our shared buffer pool? That's an additional alloc for the
bufio.{Reader/Writer}
, but we get better byte slice reuse.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get to reuse the whole thing here which is probably net better for the GC.