Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webtransport: only add cert hashes if we already started listening #2271

Merged
merged 1 commit into from
May 5, 2023
Merged

webtransport: only add cert hashes if we already started listening #2271

merged 1 commit into from
May 5, 2023

Conversation

marten-seemann
Copy link
Contributor

No description provided.

@marten-seemann marten-seemann force-pushed the webtransport-add-cert-hash-dont-wait branch from af96e15 to 4151cd5 Compare May 5, 2023 10:19
@hacdias hacdias mentioned this pull request May 5, 2023
Merged
5 tasks
@MarcoPolo
Copy link
Collaborator

CI is not happy though

@BigLep
Copy link
Contributor

BigLep commented May 5, 2023

go-libp2p maintainers: are we going to add a unit tests here?

@MarcoPolo MarcoPolo force-pushed the webtransport-add-cert-hash-dont-wait branch from 6cc7235 to 2a0242a Compare May 5, 2023 16:47
marten-seemann
marten-seemann commented May 5, 2023
View reviewed changes
Copy link
Contributor Author

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all!

@marten-seemann marten-seemann merged commit b456165 into master May 5, 2023
MarcoPolo pushed a commit that referenced this pull request May 5, 2023
@marten-seemann @MarcoPolo
webtransport: only add cert hashes if we already started listening (#…
6644291 
…2271)
MarcoPolo pushed a commit that referenced this pull request May 5, 2023
@marten-seemann @MarcoPolo
webtransport: only add cert hashes if we already started listening (#…
54a2ac3 
…2271)
MarcoPolo added a commit that referenced this pull request May 5, 2023
@MarcoPolo @marten-seemann
Release v0.27.2 (#2270)
6a96cb0 
* quic: fix race condition when generating random holepunch packet (#2263)

* webtransport: only add cert hashes if we already started listening (#2271)

* Release version v0.27.2

---------

Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann left review comments

@MarcoPolo MarcoPolo MarcoPolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marten-seemann @MarcoPolo @BigLep @aschmahmann