swarm: fix stale DialBackoff comment #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
changed the title
sukunrt
force-pushed
the
sukun/fix-dialbackoff-comment
branch
from
107b501
to
075577c
Compare
sukunrt
force-pushed
the
sukun/fix-dialbackoff-comment
branch
from
075577c
to
f946428
Compare
marten-seemann
approved these changes
Jun 12, 2023
| // addresses of a peer, we add the addresses to DialBackoff. Then, whenever we | ||
| // attempt to dial the peer again, we check each address for backoff. If it's on | ||
| // backoff, we don't dial the address and exit promptly. If a dial is | ||
| // successful, the peer and all its addresses are removed from backoff. |
There was a problem hiding this comment.
Do we? That's probably something we should clean up at some point...
There was a problem hiding this comment.
I'm assuming you mean if we clear the backoffs on success. We remove the peer from the backoff map effectively clearing all addresses.
https://github.com/libp2p/go-libp2p/blob/v0.27.0/p2p/net/swarm/swarm.go#L320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes comment suggesting we dial an address via one goroutine when it's on backoff. We do not do so.
Removes old code snippets.