core/crypto: restrict RSA keys to <= 8192 bits #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Could it be that you missed a few cases? I'm less worried about the code path where you generate the RSA key yourself (although we should prevent that footgun as well), but more about those where the peer sends us its pubkey. What could path would be taken during the TLS / Noise handshake when we receive the peer's key?
marten-seemann
changed the title
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
PublicKeyFromProto uses |
marten-seemann
approved these changes
Aug 3, 2023
marten-seemann
added a commit
that referenced
this pull request
Aug 3, 2023
* Error if RSA key is too big * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Fix rename * Make this var again so the tests work --------- Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
added a commit
that referenced
this pull request
Aug 3, 2023
* Error if RSA key is too big * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Fix rename * Make this var again so the tests work --------- Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
added a commit
that referenced
this pull request
Aug 3, 2023
* Error if RSA key is too big * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Fix rename * Make this var again so the tests work --------- Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
added a commit
that referenced
this pull request
Aug 3, 2023
* Error if RSA key is too big * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Fix rename * Make this var again so the tests work --------- Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
added a commit
that referenced
this pull request
Aug 3, 2023
* Error if RSA key is too big * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Fix rename * Make this var again so the tests work --------- Co-authored-by: Marten Seemann <martenseemann@gmail.com>
marten-seemann
added a commit
that referenced
this pull request
Aug 4, 2023
* Error if RSA key is too big * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Update core/crypto/rsa_common.go Co-authored-by: Marten Seemann <martenseemann@gmail.com> * Fix rename * Make this var again so the tests work --------- Co-authored-by: Marten Seemann <martenseemann@gmail.com>
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Aug 4, 2023
Restrict the RSA key sizes we expect from peers. Protects us from spending a lot of compute on verifying signatures from big keys. Similar to libp2p/go-libp2p#2454 --------- Co-authored-by: achingbrain <alex@achingbrain.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a certain point these become too much effort to compute. This limits the max size.