Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaults: do TLS by default for encryption #2650

Merged
merged 2 commits into from
Jan 24, 2024

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    7503e3c View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. defaults: do TLS by default for encryption

    Tls has much better throughput, the handshake benchmark is fairly noisy, there is no significant performance difference, however it does allocate more.
    
    ```
    goos: linux
    goarch: amd64
    cpu: AMD Ryzen 5 3600 6-Core Processor
    BenchmarkNoise/throughput/32KiB-12 24984	     46605 ns/op	 703.10 MB/s	      37 B/op	       2 allocs/op
    BenchmarkNoise/throughput/1MiB-12   1134	   1459483 ns/op	 718.46 MB/s	     663 B/op	      34 allocs/op
    BenchmarkNoise/handshakes-12        1302	   1054533 ns/op	   32691 B/op	     348 allocs/op
    BenchmarkTls/throughput/32KiB-12   49006	     24309 ns/op	1347.99 MB/s	      50 B/op	       2 allocs/op
    BenchmarkTls/throughput/1MiB-12     1747	    778498 ns/op	1346.92 MB/s	    1603 B/op	      64 allocs/op
    BenchmarkTls/handshakes-12          1116           1045475 ns/op	  105257 B/op	    1478 allocs/op
    ```
    Jorropo committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    843e66b View commit details
    Browse the repository at this point in the history