webrtc: use a common logger for all pion logging #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
webrtc-common-logger
branch
from
8014f41
to
07ddda5
Compare
sukunrt
force-pushed
the
webrtc-listener-close
branch
2 times, most recently
from
b841e65
to
796429f
Compare
Internally pion uses a lot of logger objects. It's better to just share one logger across everything.
sukunrt
force-pushed
the
webrtc-common-logger
branch
from
07ddda5
to
54446c7
Compare
MarcoPolo
approved these changes
Mar 4, 2024
guillaumemichel
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally pion uses a lot of logger objects. It's better to just share one logger across everything.
Depends on: #2717