fix: QUIC/Webtransport Transports now will prefer their owned listeners for dialing out #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2024
sukunrt
approved these changes
Aug 23, 2024
|
I think there's an issue here where we don't have any logic to pick the interface that can actually route the packet. |
MarcoPolo
force-pushed
the
marco/dial-from-your-own-listener
branch
from
c96307c to
7566f9f
Compare
|
I've changed this PR completely. I think it's a little cleaner now. Minimal changes to the transports, and leveraging existing logic in the quicreuse package. Another review please @sukunrt ? |
sukunrt
approved these changes
Aug 28, 2024
sukunrt
force-pushed
the
marco/dial-from-your-own-listener
branch
from
7566f9f to
0fde4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2913
The issue is presented in #2913 (comment).
The fix here introduces "associations" to refcountedTransports. a libp2p transport can associate itself with the transport used for listening, and then prefer to use that for dialing by passing itself as the association.