feat: Detect and recover from TCP Simultaneous open #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interested in trying this out for my issue, any updates on this ^^ |
|
@gdsoumya, could you try this branch to see if it solves your problem? |
sukunrt
reviewed
Dec 4, 2024
Comment on lines
+143
to
+144
| top := dq.top() | ||
| if !top.ForceDelay && dialsInFlight == 0 && !w.connected { |
There was a problem hiding this comment.
Instead of this, how about we introduce another queue:
fixedDelayQueue.
- This construct forces us to expose ForceRetry, which external users never need to use.
- Makes the semantics slightly incorrect for dials that are behind in the queue but don't have the forceRetryFlag.
I suggest introducing:
- a separate fixed Delay Queue with its separate fixedDelayTimer
- adding a
now time.Timeargument to NextBatch that'll return elements that have expired by now - Have two blocks for handling dials, 1 for dialQueue and 1 for fixedDelayDialQueue.
I don't feel strongly about the suggestion. Anything that fixes 2 would be great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2925
This touches one of the trickiest parts of the codebase, so please review carefully @sukunrt.
Requires multiformats/go-multistream#114 and a new release from that dep.