holepuncher: pass address function in constructor #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/addr-factory
branch
from
2b5fb55
to
3e54651
Compare
sukunrt
force-pushed
the
sukun/holepunch-addrs
branch
2 times, most recently
from
2229f44
to
7b21170
Compare
sukunrt
force-pushed
the
sukun/addr-factory
branch
from
3e54651
to
f79b989
Compare
sukunrt
force-pushed
the
sukun/holepunch-addrs
branch
from
7b21170
to
8787ba7
Compare
sukunrt
force-pushed
the
sukun/addr-factory
branch
from
f79b989
to
bc8f18f
Compare
sukunrt
force-pushed
the
sukun/holepunch-addrs
branch
from
8787ba7
to
89523cb
Compare
MarcoPolo
force-pushed
the
sukun/addr-factory
branch
from
ada26c4
to
71c66ee
Compare
MarcoPolo
force-pushed
the
sukun/holepunch-addrs
branch
from
89523cb
to
bea3bdf
Compare
MarcoPolo
approved these changes
Oct 16, 2024
MarcoPolo
added a commit
that referenced
this pull request
Oct 17, 2024
* autonat: fix interaction with autorelay * Fix race in test * Use deadline from context if available for DialBack * Return hasNewAddrs correctly * nit: cleanup contains check * Shuffle peers * nits * Change comment to indicate the bug * holepuncher: pass address function in constructor (#2979) * holepunch: pass address function in constructor * nit * Remove getPublicAddrs --------- Co-authored-by: Marco Munizaga <git@marcopolo.io> * Make a copy of the multiaddr slice in Addrs() --------- Co-authored-by: Marco Munizaga <git@marcopolo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2966