fix(identify): push should not dial a new connection #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
reviewed
Nov 12, 2024
p2p/protocol/identify/id.go
Outdated
|
|
||
| // We only want to send an identify push if we already have an open | ||
| // connection. | ||
| ctx = network.WithNoDial(ctx, "id push") | ||
| str, err := ids.Host.NewStream(ctx, c.RemotePeer(), IDPush) |
There was a problem hiding this comment.
Should we create the stream explicitly on the connection and do multistream select explicitly like we do for identify(non push). This might use a different connection to open the stream.
There was a problem hiding this comment.
Yeah, that's better. done on b53c174
sukunrt
approved these changes
Nov 13, 2024
MarcoPolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small window after a peer disconnects, but before identify has updated its conn map that would cause the host to dial a peer in order to send a push message. This prevents that