fix(eventbus): Idempotent wildcardSub close #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests expects the wildcardSub .Close to be idempotent, but it never checked this. The tests also weirdly asserted that there were orphaned events on the channel. That was wrong as the events should be flushed on close as to not indefinitely block an emitter.
MarcoPolo
force-pushed
the
marco/fix-eventbus-test
branch
from
f1ad9ac to
e5b739e
Compare
|
This is causing flakiness in other PRs, so merging this now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests expects the wildcardSub .Close to be idempotent, but it never checked this. The tests also weirdly asserted that there were orphaned events on the channel. That was wrong as the events should be flushed on close as to not indefinitely block an emitter.
The wrong test is what causes #3039 to fail.