refactor(core/routing): split ContentRouting interface #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
reviewed
Nov 19, 2024
|
Chiming in to say I agree with this direction - IPNI is a good example of a system where we've run into issues with there being a desire for the system to support provides as IPFS defines in delegated routing as part of being able to be used for queries. |
The ContentRouting interface does too much. One can think of systems that only Provide, and systems that only FindProviders. Therefore I am proposing to split it further. While this can be done on user-code, core/routing interfaces are canonical and it is better to use interfaces coming from here. As someone said: the best interface is that which does as little as possible.
hsanjuan
force-pushed
the
split-content-routing-interface
branch
from
731e87e to
7ee1eaa
Compare
sukunrt
reviewed
Nov 19, 2024
MarcoPolo
approved these changes
Nov 19, 2024
MarcoPolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ContentRouting interface does too much. One can think of systems that only Provide, and systems that only FindProviders.
Therefore I am proposing to split it further. While this can be done on user-code, core/routing interfaces are canonical and it is better to use interfaces coming from here.
As someone said: the best interface is that which does as little as possible.