Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Install specific protoc version when generating protobufs #3112

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

MarcoPolo
Copy link
Collaborator

@MarcoPolo MarcoPolo commented Dec 18, 2024

This fixes the issue where CI is using a different version of protoc/protoc-gen-go from our local environment. It downloads the specified version of the protobuf binary for the current system and verifies its hash. Current supported systems are macOS-aarch64 and linux-{x86_64,aarch64}. This is only used when we are regenerating the protobufs, so likely not something we will often run into.

Now the generated pbs should be reproducible locally and on CI.

@MarcoPolo
Copy link
Collaborator Author

merging without another review since this is causing every other PR to fail the check.

@MarcoPolo MarcoPolo merged commit b07e3aa into master Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant