Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various identify fixes and nits #922

Merged
merged 12 commits into from
May 14, 2020
Merged

various identify fixes and nits #922

merged 12 commits into from
May 14, 2020

Commits on May 13, 2020

  1. refactor IDService and add peerloop

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    5f1fb4f View commit details
    Browse the repository at this point in the history

  2. second draft

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c254773 View commit details
    Browse the repository at this point in the history

  3. better tests

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    d9dde9b View commit details
    Browse the repository at this point in the history

  4. fixed tests

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    1583b08 View commit details
    Browse the repository at this point in the history

  5. remove races

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    8f715ad View commit details
    Browse the repository at this point in the history

  6. fixed comment

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    a2bb2ff View commit details
    Browse the repository at this point in the history

  7. remove broadcast

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e85f5f2 View commit details
    Browse the repository at this point in the history

  8. backward compatible protocol

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    226e7ec View commit details
    Browse the repository at this point in the history

  9. changes as per review

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    1fddb7d View commit details
    Browse the repository at this point in the history

  10. go fmt

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    a01d732 View commit details
    Browse the repository at this point in the history

  11. restart peer handler

    @aarshkshah1992
    aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e1680c2 View commit details
    Browse the repository at this point in the history

  12. various identify fixes and nits 

    * Always send the correct observed addr for the connection being identified.
* Always send the correct addresses for the connection being identified.
* Avoid extra work when the remote peer doesn't support identify delta.
* Instead of applying delta locally, just update the snapshot with the new protocols.
* Always access the snapshot under a lock and get rid of the test
channel. This doesn't cost us in terms of performance and makes the system
easier to reason about.
    @Stebalien @aarshkshah1992
    Stebalien authored and aarshkshah1992 committed May 13, 2020
    Configuration menu
    Copy the full SHA
    355fd08 View commit details
    Browse the repository at this point in the history