fix: remove old addresses in identify immediately #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we'd keep addresses discovered through the DHT for up to 2 minutes (temporary TTL) and previously seen addresses (recently connected) for up to 10 minutes (the TTL). 1. Make sure to downgrade both connected and recently connected addresses to the "temporary" ttl before adding new addresses. 2. Finally, downgrade addresses with the temporary TTL to 0. This could be more efficient with a better peerstore abstraction, but this is better than nothing.
aschmahmann
approved these changes
May 28, 2020
Comment on lines
+83
to
84
| testKnowsAddrs(t, h1, h2p, h2.Addrs()) // has them | ||
| testHasCertifiedAddrs(t, h1, h2p, h2.Peerstore().Addrs(h2p)) // should have signed addrs also |
There was a problem hiding this comment.
I'm not sure I understand all the test changes. Why are we sometimes using h.Addrs() and sometimes using h.Peerstore().Addrs(h.ID)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd keep addresses discovered through the DHT for up to 2 minutes (temporary TTL) and previously seen addresses (recently connected) for up to 10 minutes (the TTL).
This could be more efficient with a better peerstore abstraction, but this is better than nothing.